2018-02-17T00:13:08 *** Fraser_Bell has joined #opensuse-admin 2018-02-17T00:18:02 *** cboltz has quit IRC 2018-02-17T00:48:16 *** Fraser_Bell has quit IRC 2018-02-17T00:55:35 *** Fraser_Bell has joined #opensuse-admin 2018-02-17T02:55:48 *** malcolmlewis has quit IRC 2018-02-17T02:56:08 *** malcolmlewis has joined #opensuse-admin 2018-02-17T03:31:11 *** Son_Goku has joined #opensuse-admin 2018-02-17T03:41:19 *** okurz has quit IRC 2018-02-17T03:43:10 *** okurz has joined #opensuse-admin 2018-02-17T04:16:42 *** malcolmlewis has quit IRC 2018-02-17T04:17:03 *** malcolmlewis has joined #opensuse-admin 2018-02-17T04:28:37 *** Son_Goku has quit IRC 2018-02-17T05:30:53 *** a-865k has quit IRC 2018-02-17T05:31:19 *** a-865 has joined #opensuse-admin 2018-02-17T05:31:33 *** a-865 is now known as a-865k 2018-02-17T06:10:38 *** Fraser_Bell has quit IRC 2018-02-17T06:18:05 *** cthugha has joined #opensuse-admin 2018-02-17T06:21:37 *** ldevulder has quit IRC 2018-02-17T07:15:19 *** dddh has quit IRC 2018-02-17T07:20:25 *** dddh has joined #opensuse-admin 2018-02-17T07:43:09 *** lcp has joined #opensuse-admin 2018-02-17T09:34:57 *** Son_Goku has joined #opensuse-admin 2018-02-17T09:45:25 *** Son_Goku has quit IRC 2018-02-17T10:23:42 PROBLEM: Hosts syslog on monitor.infra.opensuse.org - CRITICAL: Found files older than 600 minutes /var/log/opensuse/hosts//wikisearch.log was last modified on Wed Feb 7 00:15:01 2018 ; See https://monitor.opensuse.org/icinga/cgi-bin/extinfo.cgi?type=2&host=monitor.infra.opensuse.org&service=Hosts%20syslog 2018-02-17T10:32:38 *** cboltz has joined #opensuse-admin 2018-02-17T11:02:21 *** Son_Goku has joined #opensuse-admin 2018-02-17T11:26:27 *** Aksem has joined #opensuse-admin 2018-02-17T11:40:06 *** King_InuYasha has joined #opensuse-admin 2018-02-17T11:43:46 *** Son_Goku has quit IRC 2018-02-17T11:55:12 *** thomic_ has joined #opensuse-admin 2018-02-17T11:57:54 *** okurz_ has joined #opensuse-admin 2018-02-17T11:58:47 *** _miska_ has joined #opensuse-admin 2018-02-17T11:58:57 *** okurz has quit IRC 2018-02-17T11:58:57 *** okurz_ is now known as okurz 2018-02-17T12:00:08 *** |miska| has quit IRC 2018-02-17T12:00:09 *** thomic has quit IRC 2018-02-17T12:00:10 *** _miska_ is now known as |miska| 2018-02-17T12:00:10 *** |miska| has joined #opensuse-admin 2018-02-17T12:03:02 *** fvogt has joined #opensuse-admin 2018-02-17T12:30:14 *** jeberhardt has left #opensuse-admin 2018-02-17T12:38:50 *** Aksem has quit IRC 2018-02-17T12:43:30 *** Aksem has joined #opensuse-admin 2018-02-17T13:03:08 *** King_InuYasha is now known as Son_Goku 2018-02-17T13:11:03 *** lcp has quit IRC 2018-02-17T16:09:12 *** lcp has joined #opensuse-admin 2018-02-17T17:02:02 tampakrap: am I blind, or do we really not have a basic postfix config (basically setting "relayhost = [relay.infra.opensuse.org]") in salt? 2018-02-17T17:06:30 we don't 2018-02-17T17:09:18 also we need to set the root alias to send mails to admin-auto 2018-02-17T17:11:08 are you bored enough to do this? ;-) 2018-02-17T17:24:58 tampakrap: https://github.com/openSUSE/helios-server/pull/9 - please review and update the package 2018-02-17T17:27:10 you might also want to pull the latest upstream changes 2018-02-17T17:27:49 *** tigerfoot has joined #opensuse-admin 2018-02-17T17:36:13 you don't have perms to update the package and pull in the latest changes? 2018-02-17T17:36:41 I'd like to have a second pair of eyes on election-related stuff ;-) 2018-02-17T17:42:37 *** fvogt has quit IRC 2018-02-17T17:43:49 *** fvogt has joined #opensuse-admin 2018-02-17T17:56:26 *** Son_Goku has quit IRC 2018-02-17T18:38:42 cboltz: I'm thinking if we should probably use your MR as custom patch so that we can drop the fork 2018-02-17T18:41:19 or a patch for auth_systems/__init__.py and keep opensuse.py as static file 2018-02-17T18:49:47 I already had the same thought - that makes things (especially grabbing the latest upstream version) easier on the longer term 2018-02-17T18:52:10 can we avoid adding the icon and using static.o.o instead? 2018-02-17T18:53:30 IIRC the path is somewhat hardcoded in helios (/static/auth/login-icons/$auth_method.png) 2018-02-17T18:55:14 okay 2018-02-17T19:03:35 *** dddh has quit IRC 2018-02-17T19:47:24 cboltz: https://build.opensuse.org/request/show/577637 2018-02-17T19:50:14 [ 50s] helios-server.src: W: patch-not-applied Patch1: %{name}-opensuse_auth.patch 2018-02-17T19:54:02 ah 2018-02-17T19:54:12 *** Son_Goku has joined #opensuse-admin 2018-02-17T20:00:03 PROBLEM: HAProxy on mufasa.infra.opensuse.org - HAPROXY CRITICAL - Active service riesling is DOWN on riesling proxy ! Active service narwal4 is DOWN on static proxy ! ; See https://monitor.opensuse.org/icinga/cgi-bin/extinfo.cgi?type=2&host=mufasa.infra.opensuse.org&service=HAProxy 2018-02-17T20:33:23 cboltz: when it finishes the tests will fail https://build.opensuse.org/package/live_build_log/home:tampakrap:branches:openSUSE:infrastructure:elections.opensuse.org/helios-server/openSUSE_Leap_42.3/x86_64 2018-02-17T20:36:43 nice[tm] 2018-02-17T20:39:19 can you change line 51 of opensuse.py to 2018-02-17T20:39:39 if user_id in settings.get('CELECTION_CREATORS', {}): 2018-02-17T20:39:42 and try again? 2018-02-17T20:40:03 actually 2018-02-17T20:40:11 if user_id in settings.get('ELECTION_CREATORS', {}): 2018-02-17T20:40:29 I somehow managed to introduce a typo in my quick tests :-/ 2018-02-17T20:40:58 *** Son_Goku has quit IRC 2018-02-17T20:46:04 if this doesn't work, we'll probably need to patch settings.py so that ELECTION_CREATORS is set (maybe to an empty value) 2018-02-17T20:48:08 okay 2018-02-17T20:59:08 cboltz: still fil 2018-02-17T20:59:11 fail* 2018-02-17T20:59:56 damn, settings is an object, not a plain dict 2018-02-17T21:00:13 ok, give me a minute to update settings.py on github and to make a new pull request 2018-02-17T21:00:37 (and obviously revert the changes in opensuse.py) 2018-02-17T21:08:09 https://github.com/openSUSE/helios-server/pull/10 2018-02-17T21:39:56 cboltz: failed again 2018-02-17T21:40:06 different error 2018-02-17T21:43:19 http://paste.opensuse.org/23826657 is the test code 2018-02-17T21:44:10 it might sound funny, but changing settings.py to ELECTION_CREATORS = [ 'foobar' ] should help 2018-02-17T21:47:13 *** dddh has joined #opensuse-admin 2018-02-17T21:47:13 *** dddh has joined #opensuse-admin 2018-02-17T21:50:47 https://github.com/openSUSE/helios-server/pull/10 updated 2018-02-17T21:51:36 okay building 2018-02-17T21:52:32 *** lcp has quit IRC 2018-02-17T21:54:17 it passed now, but the overall build failed due to too many warnings 2018-02-17T21:54:44 [ 50s] helios-server.noarch: E: suse-filelist-forbidden (Badness: 10000) /usr/lib/python2.7/site-packages/helios-server/settings.py.orig is not allowed in SUSE 2018-02-17T21:55:32 can I move the patching of the settings.py only to the %check part? 2018-02-17T21:56:50 that sounds evil 2018-02-17T21:57:11 the typical reason for *.orig files is that the patch doesn't apply cleanly, so you'll "just" need to rebase it 2018-02-17T21:57:54 [ 37s] Hunk #1 succeeded at 215 (offset 3 lines). 2018-02-17T21:58:21 so change 2018-02-17T21:58:25 @@ -212,6 +212,10 @@ def get_from_env(var, default): 2018-02-17T21:58:26 to 2018-02-17T21:58:37 @@ -215,6 +215,10 @@ def get_from_env(var, default): 2018-02-17T21:58:51 (that's s/212/215/g) 2018-02-17T21:59:24 so we need to have this variable set to foobar in production as well? 2018-02-17T22:00:24 no, production gets a salt-managed settings.py 2018-02-17T22:01:10 then why not to do it only for the tests? 2018-02-17T22:02:56 settings.py needs to be modified / replaced for production anyway, therefore it doesn't hurt to have this in the packaged file 2018-02-17T22:04:11 is it useful though? 2018-02-17T22:04:45 maybe it would be better to leave it empty at the package and put a fake value for the tests only? 2018-02-17T22:04:53 the combination of "doesn't hurt" and "needed to run the tests" makes it useful IMHO ;-) 2018-02-17T22:05:10 also, if someone installs the package and runs the tests it will be useful 2018-02-17T22:06:32 okay 2018-02-17T22:06:37 building again 2018-02-17T22:09:16 success, 577645 2018-02-17T22:12:29 looks good :-) 2018-02-17T22:38:52 *** lcp has joined #opensuse-admin 2018-02-17T22:54:25 *** lcp has quit IRC 2018-02-17T23:04:27 *** lcp has joined #opensuse-admin 2018-02-17T23:23:29 *** Son_Goku has joined #opensuse-admin 2018-02-17T23:29:03 merged 2018-02-17T23:36:44 thanks! 2018-02-17T23:37:40 and good night! ;-) 2018-02-17T23:38:05 *** fvogt has quit IRC 2018-02-17T23:40:07 *** cboltz has quit IRC 2018-02-17T23:45:40 *** lcp has quit IRC 2018-02-17T23:48:39 *** lcp has joined #opensuse-admin 2018-02-17T23:54:42 *** dddh has quit IRC