2018-01-20T00:05:35 *** fvogt has quit IRC 2018-01-20T00:24:15 *** cboltz has quit IRC 2018-01-20T03:20:45 *** okurz has quit IRC 2018-01-20T03:21:49 *** okurz has joined #opensuse-admin 2018-01-20T03:36:36 *** Fraser_Bell has joined #opensuse-admin 2018-01-20T03:36:36 *** Fraser_Bell has joined #opensuse-admin 2018-01-20T03:52:28 *** cthugha has joined #opensuse-admin 2018-01-20T03:56:20 *** ldevulder has quit IRC 2018-01-20T04:35:58 *** Son_Goku has joined #opensuse-admin 2018-01-20T04:47:19 *** Fraser_Bell has quit IRC 2018-01-20T05:07:28 *** Son_Goku has quit IRC 2018-01-20T05:30:36 *** a-865 is now known as a-865xx 2018-01-20T05:32:18 *** a-865xx is now known as a-865-kx 2018-01-20T05:35:14 *** a-865-kx is now known as a-865-k 2018-01-20T05:43:05 *** tampakrap has quit IRC 2018-01-20T05:47:54 *** plinnell has quit IRC 2018-01-20T05:51:09 *** plinnell has joined #opensuse-admin 2018-01-20T06:53:54 *** plinnell has quit IRC 2018-01-20T07:03:28 *** plinnell has joined #opensuse-admin 2018-01-20T08:00:04 *** plinnell has quit IRC 2018-01-20T08:04:17 *** plinnell has joined #opensuse-admin 2018-01-20T09:11:15 *** tampakrap has joined #opensuse-admin 2018-01-20T09:22:57 *** Son_Goku has joined #opensuse-admin 2018-01-20T09:33:49 *** Son_Goku has quit IRC 2018-01-20T09:38:19 *** tampakrap has quit IRC 2018-01-20T09:46:07 *** tampakrap has joined #opensuse-admin 2018-01-20T09:53:15 *** BManojlovic has quit IRC 2018-01-20T09:54:54 *** BManojlovic has joined #opensuse-admin 2018-01-20T10:31:31 *** cboltz has joined #opensuse-admin 2018-01-20T11:00:11 *** tampakrap has quit IRC 2018-01-20T11:07:35 *** tampakrap has joined #opensuse-admin 2018-01-20T11:18:09 cboltz: thanks for the reviews 2018-01-20T11:18:36 can you please check !154 !156 and !157? others depend on them so I'd like to have them in first 2018-01-20T12:10:45 also !158 and !161 are ready 2018-01-20T12:12:47 hey guys 2018-01-20T12:13:32 :( 2018-01-20T12:15:35 *** cboltz has quit IRC 2018-01-20T12:15:51 *** fvogt has joined #opensuse-admin 2018-01-20T12:15:56 *** cboltz has joined #opensuse-admin 2018-01-20T12:15:56 *** cboltz has joined #opensuse-admin 2018-01-20T12:36:44 *** Son_Goku has joined #opensuse-admin 2018-01-20T12:47:21 tampakrap: for 156 and 157 - I'm not sure if I like the magic for the web role 2018-01-20T12:47:56 what about using pillar/common/web.sls and including that in all web_* roles? 2018-01-20T12:49:11 actually I wonder if this shoud be pillar/role/common/nginx.sls, and one day we might also have a pillar/role/common/apache.sls 2018-01-20T12:49:48 when naming it "web" and we want it to support apache and nginx, we'll always have 50% superfluous pillar data around 2018-01-20T12:49:49 yes that's possible 2018-01-20T12:50:13 splitting them is not really needed, if the node uses the formula, it will use the pillar data, otherwise it will ignore them 2018-01-20T12:50:40 right, it's "just superfluous" to have pillar data for both loaded 2018-01-20T12:51:25 I'm stilll a fan of this split, and if it's only to have shorter files (which are IMHO easier to read) 2018-01-20T12:53:55 okay 2018-01-20T12:55:18 for !157 this means to use special_roles = ['base'] (remove 'web') 2018-01-20T12:55:31 as a side effect, this will make the tests green ;-) 2018-01-20T12:58:00 oh, and minor nitpicking - "Append a list of given roles _to_ the results." (s/at/to) 2018-01-20T12:59:16 pillar/common/role/web/server/{nginx/apache}.sls? 2018-01-20T12:59:28 to follow the profile/web/server/{apache/nginx}.sls? 2018-01-20T13:00:07 I get your point, but it looks like a too complex directory structure 2018-01-20T13:00:42 unless you expect > 30 common pillar files, I'd just go with pillar/role/common/nginx.sls 2018-01-20T13:00:53 *** tigerfoot has quit IRC 2018-01-20T13:01:24 (the pilllar shared between wiki and wikisearch already "hides" there) 2018-01-20T13:10:41 !156 fixed, waiting for the tests to run 2018-01-20T13:30:06 !156 tests passed 2018-01-20T13:30:19 !157 web special role removed, tests running 2018-01-20T13:31:07 156 looks good, and I'll assume that the nginx config does what it should 2018-01-20T13:32:01 we'll learn in a bit 2018-01-20T13:32:43 for 157, take my +1 as "+1 if tests succeed" 2018-01-20T13:33:12 and with that said, I have to leave. See you later ;-) 2018-01-20T13:33:38 bye! 2018-01-20T13:33:49 *** cboltz has quit IRC 2018-01-20T17:33:22 *** cboltz has joined #opensuse-admin 2018-01-20T17:33:22 *** cboltz has joined #opensuse-admin 2018-01-20T17:43:35 *** Son_Goku has quit IRC 2018-01-20T18:27:47 *** Son_Goku has joined #opensuse-admin 2018-01-20T19:06:10 *** Son_Goku has quit IRC 2018-01-20T19:44:32 *** Son_Goku has joined #opensuse-admin 2018-01-20T20:00:02 PROBLEM: HAProxy on mufasa.infra.opensuse.org - HAPROXY CRITICAL - Active service riesling is DOWN on riesling proxy ! Active service narwal4 is DOWN on static proxy ! ; See https://monitor.opensuse.org/icinga/cgi-bin/extinfo.cgi?type=2&host=mufasa.infra.opensuse.org&service=HAProxy 2018-01-20T20:45:52 *** a-865-k has quit IRC 2018-01-20T20:47:40 *** a-865 has joined #opensuse-admin 2018-01-20T20:50:56 *** a-865 is now known as a-865k 2018-01-20T20:56:07 *** a-865k has quit IRC 2018-01-20T21:04:10 *** Son_Goku has quit IRC 2018-01-20T21:28:02 *** Son_Goku has joined #opensuse-admin 2018-01-20T22:05:44 *** okurz[m] has quit IRC 2018-01-20T22:05:45 *** marxin has quit IRC 2018-01-20T22:05:46 *** awafaa has quit IRC 2018-01-20T22:05:55 *** marxin has joined #opensuse-admin 2018-01-20T22:06:16 *** awafaa has joined #opensuse-admin 2018-01-20T22:08:28 *** okurz[m] has joined #opensuse-admin 2018-01-20T23:59:27 *** fvogt has quit IRC