2017-11-15T00:04:50 *** Son_Goku has quit IRC 2017-11-15T00:08:33 *** cboltz has quit IRC 2017-11-15T00:09:29 *** Son_Goku has joined #opensuse-admin 2017-11-15T00:10:19 *** Son_Goku has quit IRC 2017-11-15T00:32:12 *** Fraser_Bell has joined #opensuse-admin 2017-11-15T00:32:13 *** Fraser_Bell has joined #opensuse-admin 2017-11-15T00:49:17 *** Son_Goku has joined #opensuse-admin 2017-11-15T01:51:46 *** plinnell has quit IRC 2017-11-15T01:59:09 *** Fraser_Bell has quit IRC 2017-11-15T03:42:15 *** plinnell has joined #opensuse-admin 2017-11-15T03:42:15 *** plinnell has joined #opensuse-admin 2017-11-15T03:53:10 *** okurz has quit IRC 2017-11-15T03:53:31 *** okurz_ has joined #opensuse-admin 2017-11-15T03:53:39 *** okurz_ is now known as okurz 2017-11-15T04:03:28 *** Son_Goku has quit IRC 2017-11-15T06:36:37 *** fvogt has joined #opensuse-admin 2017-11-15T06:49:11 *** fvogt has quit IRC 2017-11-15T06:57:54 *** tigerfoot has quit IRC 2017-11-15T07:39:01 *** Son_Goku has joined #opensuse-admin 2017-11-15T07:45:13 *** fvogt has joined #opensuse-admin 2017-11-15T08:25:57 *** asmorodskyi has joined #opensuse-admin 2017-11-15T08:36:50 *** mcaj has joined #opensuse-admin 2017-11-15T08:46:34 *** tigerfoot has joined #opensuse-admin 2017-11-15T09:04:40 *** sven15 has joined #opensuse-admin 2017-11-15T09:25:52 *** matthias_bgg has joined #opensuse-admin 2017-11-15T09:34:18 *** fraya has joined #opensuse-admin 2017-11-15T09:48:39 *** Son_Goku has quit IRC 2017-11-15T09:55:11 *** plinnell has quit IRC 2017-11-15T09:56:23 *** asmorodskyi has quit IRC 2017-11-15T10:05:35 *** ldevulder has quit IRC 2017-11-15T10:17:44 *** ldevulder has joined #opensuse-admin 2017-11-15T10:25:01 *** ldevulder has quit IRC 2017-11-15T10:39:34 *** ldevulder has joined #opensuse-admin 2017-11-15T10:43:23 *** asmorodskyi has joined #opensuse-admin 2017-11-15T11:06:18 *** fraya has quit IRC 2017-11-15T11:11:35 *** Son_Goku has joined #opensuse-admin 2017-11-15T11:26:05 *** Son_Goku has quit IRC 2017-11-15T11:31:44 *** cboltz has joined #opensuse-admin 2017-11-15T11:31:44 *** cboltz has joined #opensuse-admin 2017-11-15T12:16:32 *** Son_Goku has joined #opensuse-admin 2017-11-15T12:41:18 *** matthias_bgg has quit IRC 2017-11-15T12:41:41 *** matthias_bgg has joined #opensuse-admin 2017-11-15T12:54:20 *** cboltz has quit IRC 2017-11-15T13:16:06 *** ancor is now known as ancorgs 2017-11-15T13:19:18 *** deneb_alpha has joined #opensuse-admin 2017-11-15T13:19:18 *** deneb_alpha has joined #opensuse-admin 2017-11-15T13:23:35 *** petracvv has quit IRC 2017-11-15T14:53:41 *** awafaa has quit IRC 2017-11-15T14:54:59 *** awafaa has joined #opensuse-admin 2017-11-15T15:15:56 *** mmaher_ has quit IRC 2017-11-15T15:18:31 *** Son_Goku has quit IRC 2017-11-15T15:59:59 *** asmorodskyi has quit IRC 2017-11-15T16:18:52 *** plinnell has joined #opensuse-admin 2017-11-15T16:18:52 *** plinnell has joined #opensuse-admin 2017-11-15T16:21:43 *** cboltz has joined #opensuse-admin 2017-11-15T16:21:43 *** cboltz has joined #opensuse-admin 2017-11-15T16:35:48 *** asmorodskyi has joined #opensuse-admin 2017-11-15T16:45:47 http://turnoff.us/geek/deployment-pipeline/ 2017-11-15T16:49:38 true 2017-11-15T16:51:42 *** matthias_bgg has quit IRC 2017-11-15T16:52:04 can you give me another cmd.run result? 2017-11-15T16:52:15 salt \* cmd.run 'head /etc/nrpe.d/*' 2017-11-15T16:52:18 *** matthias_bgg has joined #opensuse-admin 2017-11-15T16:57:03 *** malcolmlewis has quit IRC 2017-11-15T16:57:31 the ca-certificates-suse package shouldn't be on any system 2017-11-15T16:57:35 if it is, we need to remove it 2017-11-15T16:57:40 so remove it from the whitelist please 2017-11-15T16:58:40 the output you asked for is in riesling 2017-11-15T16:59:14 thanks! 2017-11-15T17:02:39 whitelist updated, monitoring will complain about 3 machines ;-) 2017-11-15T17:04:07 !98 and !99 ready for review 2017-11-15T17:06:38 *** sven15 has quit IRC 2017-11-15T17:08:35 *** asmorodskyi has quit IRC 2017-11-15T17:18:27 *** matthias_bgg has quit IRC 2017-11-15T17:18:40 *** malcolmlewis has joined #opensuse-admin 2017-11-15T17:23:29 which ones? 2017-11-15T17:23:33 I can remove it now from there 2017-11-15T17:27:18 *** deneb_alpha has quit IRC 2017-11-15T17:27:56 see https://gitlab.infra.opensuse.org/infra/salt/commit/0dc72679ecd03943e270ea588b21e894827e237b ;-) 2017-11-15T17:31:17 gone 2017-11-15T17:32:47 *** fvogt has quit IRC 2017-11-15T17:40:09 interesting - ls -lh /var/log/lastlog reports the file is 372GB on riesling and water 2017-11-15T17:40:31 du -h /var/log/lastlog says 152K which looks more valid 2017-11-15T17:40:47 any idea why ls -lh reports this insane size? 2017-11-15T17:41:58 lol no idea 2017-11-15T17:43:44 !98 ready for review again, I replied to your comments 2017-11-15T17:44:05 you might have lost them though because if you reply to the commit, it doesn't open an incident comment on the MR as well 2017-11-15T17:46:25 http://www.noah.org/wiki/Lastlog_is_gigantic - it's a sparse file (no surprise given the disk size), and 2017-11-15T17:46:29 space is "allocated" ahead of time for all possible user IDs, which is about 232 users multiplied by 256 bytes for each login record, which is about 1.2 TB 2017-11-15T17:47:35 ah 2017-11-15T17:47:42 so ls -lh reports the allocated space 2017-11-15T17:49:17 for !98: 2017-11-15T17:50:34 - even if you test many combinations, writing the full grains is probably easier than the sed commands, something like write_grains de nuremberg atreju Leap 42.3 2017-11-15T17:50:55 there is a function on test_show_highstate 2017-11-15T17:51:09 two functions actually 2017-11-15T17:51:38 set_os and set_location, yes 2017-11-15T17:51:47 they could both call write_grains ;-) 2017-11-15T17:52:13 (I'll assume the script always knows the values of all grains) 2017-11-15T17:52:31 how? 2017-11-15T17:52:53 ah I got it 2017-11-15T17:53:08 you write it to the grains file with sed, so just make sure to keep the variables available 2017-11-15T17:53:25 yep 2017-11-15T17:53:34 set_os could do write_grains $country $city $virt_cluster Leap 42.3 2017-11-15T17:54:46 or you change the variables you want to change ($osfullname etc.) before calling write_grains, and let write_grains fetch everything from those variables 2017-11-15T17:56:17 - for printing the errors at the end, the reason is simply that the overview page on gitlab shows only the last lines, so it would be useful to have the list of failed tests there 2017-11-15T17:56:35 (and even when checking the full output, I always start at the end when searching for errors) 2017-11-15T17:57:05 the overview page is useless, you actually need to open it to see the errors 2017-11-15T17:57:33 even if I write them at the end, you'll still get a part of the error 2017-11-15T17:58:45 there's at least https://gitlab.infra.opensuse.org/infra/salt/pipelines/440/failures 2017-11-15T17:59:00 probably not the page you check first, but it's useful to get the last lines 2017-11-15T17:59:13 (and yes, the pages you typically check first don't show any of the output) 2017-11-15T18:02:46 one of your latest commits uses grep -lr "\- secrets\. pillar/" - that won't find anything... (we only have secrets.role.something, secrets.pillar doesn't really make sense) 2017-11-15T18:03:41 ah, and the next commit fixes that :-) 2017-11-15T18:04:49 fixed 2017-11-15T18:08:05 I'm not sure if write_grains() does what you expect 2017-11-15T18:08:17 the echo uses $1..$5 (which looks like a good idea) 2017-11-15T18:08:37 but the sed only uses $1..$3, and uses $1 and $2 twice 2017-11-15T18:08:59 correct 2017-11-15T18:09:19 I will also move out of the sed the rest 2017-11-15T18:09:27 out of the *function* the rest 2017-11-15T18:10:02 I'd recommend to always have valid values in all grains, which also means to always call the function with 5 parameters 2017-11-15T18:12:11 done 2017-11-15T18:18:05 aaaand it failed 2017-11-15T18:45:57 I never asked you to introduce a bug in the script ;-) 2017-11-15T18:51:25 cboltz: now it's green 2017-11-15T18:55:57 nice :-) 2017-11-15T18:56:44 I still think that write_grains() should write the full file with printf instead of doing sed replacements, but I won't insist on that 2017-11-15T18:57:15 so if you really want to keep sed, feel free to merge as is 2017-11-15T18:57:23 cool merged 2017-11-15T18:57:40 and !97? 2017-11-15T19:00:00 what's the reason for silently ignoring ValueError in add_remote? 2017-11-15T19:00:18 it already exists 2017-11-15T19:01:57 so you just were too lazy to first check if the to-be-added remote already exists? 2017-11-15T19:02:01 ok, that's a reason ;-) 2017-11-15T19:02:42 to check if it exists, I need to iterate 2017-11-15T19:03:12 no problem, but a comment explaining why you silently ignore ValueError would be a good idea 2017-11-15T19:03:39 can the ValueError also happen in fetch_remote? (asking because you moved that call into the try block) 2017-11-15T19:04:13 no 2017-11-15T19:04:33 then I'd prefer to have the fetch_remote call outside the try/except 2017-11-15T19:05:11 but I don't want to fetch an existing remote 2017-11-15T19:05:27 if it doesn't exist, add and fetch it 2017-11-15T19:05:31 if it exists, do nothing 2017-11-15T19:05:34 ah, ok 2017-11-15T19:06:10 what about replacing the "pass" (in except:) with "return" + a comment? 2017-11-15T19:06:54 return won't iterate to the next to-be-added remote 2017-11-15T19:07:00 pass or continue 2017-11-15T19:07:25 so I could add continue and move the fetch_remote out 2017-11-15T19:08:20 sounds better? 2017-11-15T19:09:09 correct me if I'm wrong, but - fetch_remote doesn't have a loop, so it's probably called once for each remote 2017-11-15T19:09:23 which also means "return" should work 2017-11-15T19:09:49 there is a for loop that iterates through the given remotes from the command line 2017-11-15T19:10:26 then it goes to each formula and either adds+fetches the remote, or does nothing if it is already there 2017-11-15T19:12:28 argh, I somehow managed to confuse add_remote with fetch_remote :-( (probably by some funny effect in viewing only the latest diff instead of the full one) 2017-11-15T19:13:00 | try: 2017-11-15T19:13:02 | repo.create_remote(name, full_url) 2017-11-15T19:13:04 | except ValueError: 2017-11-15T19:13:06 | - pass 2017-11-15T19:13:08 | + # remote already exists 2017-11-15T19:13:10 | + continue 2017-11-15T19:13:12 | fetch_remote(repo.remotes[name], formula) 2017-11-15T19:13:14 better? 2017-11-15T19:14:13 yes, except that I'd do the comments slightly different: 2017-11-15T19:14:21 except ValueError: # remote already exists 2017-11-15T19:14:47 okay 2017-11-15T19:14:48 continue # ... so don't call fetch_remote 2017-11-15T19:15:11 (something like that - my texts aren't perfect, but you should get the point ;-) 2017-11-15T19:15:57 just the first comment is fine 2017-11-15T19:16:30 pushed 2017-11-15T19:18:04 *** fvogt has joined #opensuse-admin 2017-11-15T19:20:44 looks good :-) 2017-11-15T19:23:43 just looking through the nrpe.d list 2017-11-15T19:23:53 some of the machines run a check_swap check 2017-11-15T19:24:07 do they really have a swap partition, or is this check superfluous? 2017-11-15T19:24:27 some do yes 2017-11-15T19:24:46 the jeos image changed to not have a swap around a year plus ago 2017-11-15T19:24:52 maybe more, don't remember 2017-11-15T19:25:07 I'm afk for the rest of the evening, see you tomorrow 2017-11-15T19:25:20 enjoy the evening ;-) 2017-11-15T19:31:34 *** ldevulder has quit IRC 2017-11-15T19:50:05 *** fvogt has quit IRC 2017-11-15T19:55:19 *** fvogt has joined #opensuse-admin 2017-11-15T21:10:30 *** petracvv has joined #opensuse-admin 2017-11-15T21:28:13 *** tigerfoot has quit IRC 2017-11-15T22:07:27 *** fvogt has quit IRC 2017-11-15T23:07:56 *** tigerfoot has joined #opensuse-admin 2017-11-15T23:22:17 *** Son_Goku has joined #opensuse-admin 2017-11-15T23:30:31 *** Son_Goku has quit IRC 2017-11-15T23:40:19 *** Son_Goku has joined #opensuse-admin 2017-11-15T23:52:40 *** cboltz has quit IRC