2017-11-08T00:37:55  *** Fraser_Bell has quit IRC
2017-11-08T01:18:34  *** Son_Goku has quit IRC
2017-11-08T02:08:43  *** Son_Goku has joined #opensuse-admin
2017-11-08T02:50:36  *** Son_Goku has quit IRC
2017-11-08T04:01:41  *** okurz has quit IRC
2017-11-08T04:02:26  *** okurz has joined #opensuse-admin
2017-11-08T04:12:28  *** nicolasbock has quit IRC
2017-11-08T05:15:10  *** dddh__ has quit IRC
2017-11-08T05:15:33  *** dddh__ has joined #opensuse-admin
2017-11-08T05:29:24  *** dddh_ has quit IRC
2017-11-08T05:29:47  *** dddh_ has joined #opensuse-admin
2017-11-08T05:30:09  *** dddh__ has quit IRC
2017-11-08T05:31:04  *** dddh__ has joined #opensuse-admin
2017-11-08T05:31:04  *** dddh__ has joined #opensuse-admin
2017-11-08T05:52:51  *** paka has quit IRC
2017-11-08T06:02:43  *** paka has joined #opensuse-admin
2017-11-08T06:08:11  *** plinnell has quit IRC
2017-11-08T06:24:03  *** plinnell has joined #opensuse-admin
2017-11-08T06:24:03  *** plinnell has joined #opensuse-admin
2017-11-08T06:26:15  *** mgriessmeier has left #opensuse-admin
2017-11-08T06:27:25  *** asmorodskyi has joined #opensuse-admin
2017-11-08T06:42:33  *** tigerfoot has joined #opensuse-admin
2017-11-08T06:51:51  *** plinnell has quit IRC
2017-11-08T07:17:27  *** asmorodskyi has quit IRC
2017-11-08T07:50:05  *** solevi_ has quit IRC
2017-11-08T07:54:07  *** sven15 has joined #opensuse-admin
2017-11-08T07:54:42  *** solevi_ has joined #opensuse-admin
2017-11-08T07:56:24  *** ancorgs has joined #opensuse-admin
2017-11-08T07:58:28  *** asmorodskyi has joined #opensuse-admin
2017-11-08T08:04:23  *** jdsn has quit IRC
2017-11-08T08:07:53  *** dddh_ has quit IRC
2017-11-08T08:08:12  *** dddh__ has quit IRC
2017-11-08T08:08:19  *** dddh_ has joined #opensuse-admin
2017-11-08T08:08:19  *** dddh_ has joined #opensuse-admin
2017-11-08T08:16:12  *** dddh__ has joined #opensuse-admin
2017-11-08T08:16:13  *** dddh__ has joined #opensuse-admin
2017-11-08T08:16:33  *** sven15 has quit IRC
2017-11-08T08:23:24  *** dddh is now known as dddh___
2017-11-08T08:23:30  *** dddh__ is now known as dddh
2017-11-08T08:23:35  *** dddh___ is now known as dddh__
2017-11-08T08:27:39  *** kl_eisbaer has joined #opensuse-admin
2017-11-08T08:27:39  *** kl_eisbaer has joined #opensuse-admin
2017-11-08T08:33:00  *** sven15 has joined #opensuse-admin
2017-11-08T08:33:16  *** ChanServ sets mode: +o kl_eisbaer
2017-11-08T08:35:26  *** ancorgs has quit IRC
2017-11-08T08:40:34  *** kl_eisbaer changes topic to "Channel-Log: https://monitor.opensuse.org/heroes/ | https://progress.opensuse.org/projects/opensuse-admin/news | report problems to mailto:admin@opensuse.org | https://status.opensuse.org/"
2017-11-08T08:40:48  *** kl_eisbaer has left #opensuse-admin
2017-11-08T08:41:46  *** kl_eisbaer has joined #opensuse-admin
2017-11-08T09:02:55  *** ancorgs has joined #opensuse-admin
2017-11-08T09:06:33  *** plinnell has joined #opensuse-admin
2017-11-08T09:06:33  *** plinnell has joined #opensuse-admin
2017-11-08T09:13:49  *** mcaj has joined #opensuse-admin
2017-11-08T09:42:56  *** dddh has quit IRC
2017-11-08T09:42:57  *** dddh_ has quit IRC
2017-11-08T09:43:23  *** plinnell has quit IRC
2017-11-08T09:43:23  *** kl_eisbaer has quit IRC
2017-11-08T09:43:27  *** plusky has quit IRC
2017-11-08T09:43:28  *** mmaher_ has quit IRC
2017-11-08T09:43:37  *** dddh_ has joined #opensuse-admin
2017-11-08T09:44:14  *** dddh has joined #opensuse-admin
2017-11-08T09:44:14  *** dddh has joined #opensuse-admin
2017-11-08T09:46:27  *** |miska| has quit IRC
2017-11-08T09:46:44  *** |miska| has joined #opensuse-admin
2017-11-08T09:46:44  *** |miska| has joined #opensuse-admin
2017-11-08T09:46:52  *** okurz[m] has quit IRC
2017-11-08T09:46:53  *** cboltz has joined #opensuse-admin
2017-11-08T09:46:53  *** cboltz has joined #opensuse-admin
2017-11-08T09:47:32  *** aboe[m] has quit IRC
2017-11-08T09:49:00  *** plinnell has joined #opensuse-admin
2017-11-08T09:49:00  *** kl_eisbaer has joined #opensuse-admin
2017-11-08T09:49:00  *** plusky has joined #opensuse-admin
2017-11-08T09:49:00  *** mmaher_ has joined #opensuse-admin
2017-11-08T09:58:44  *** dddh has quit IRC
2017-11-08T09:59:18  *** dddh has joined #opensuse-admin
2017-11-08T10:02:56  *** aboe[m] has joined #opensuse-admin
2017-11-08T10:36:26  *** sven15 has quit IRC
2017-11-08T10:44:36  *** okurz[m] has joined #opensuse-admin
2017-11-08T10:50:13  *** sven15 has joined #opensuse-admin
2017-11-08T11:11:52  *** Son_Goku has joined #opensuse-admin
2017-11-08T11:42:42  <tampakrap> kl_eisbaer / cboltz: https://gitlab.infra.opensuse.org/infra/salt/merge_requests/75
2017-11-08T11:55:49  *** mmaher_ has quit IRC
2017-11-08T11:56:13  *** mmaher_ has joined #opensuse-admin
2017-11-08T12:02:51  *** nicolasbock has joined #opensuse-admin
2017-11-08T12:03:28  <tampakrap> gitlab going down for update
2017-11-08T13:18:07  <tampakrap> cboltz: on https://gitlab.infra.opensuse.org/infra/salt/merge_requests/73 I moved the password to pillar/secrets/ as agreed
2017-11-08T13:27:16  *** Guest42402 has joined #opensuse-admin
2017-11-08T13:43:08  *** Guest42402 has quit IRC
2017-11-08T14:28:04  <cboltz> both reviewed
2017-11-08T15:09:29  *** victorhck has joined #opensuse-admin
2017-11-08T15:09:46  *** victorhck has joined #opensuse-admin
2017-11-08T15:23:54  *** solevi has joined #opensuse-admin
2017-11-08T15:51:07  *** asmorodskyi has quit IRC
2017-11-08T16:04:01  *** IonutVan_ has quit IRC
2017-11-08T16:05:55  *** IonutVan_ has joined #opensuse-admin
2017-11-08T16:09:29  *** mcaj has quit IRC
2017-11-08T16:19:57  *** dddh has quit IRC
2017-11-08T16:29:32  *** dddh_ has quit IRC
2017-11-08T16:29:55  *** dddh_ has joined #opensuse-admin
2017-11-08T16:32:49  *** dddh has joined #opensuse-admin
2017-11-08T16:32:49  *** dddh has joined #opensuse-admin
2017-11-08T16:43:41  *** Son_Goku has quit IRC
2017-11-08T16:44:26  <heroes-bot> PROBLEM: HTTP progress on redmine.infra.opensuse.org - HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - 968 bytes in 6.022 second response time ; See https://monitor.opensuse.org/icinga/cgi-bin/extinfo.cgi?type=2&host=redmine.infra.opensuse.org&service=HTTP%20progress
2017-11-08T16:54:19  <heroes-bot> RECOVERY: HTTP progress on redmine.infra.opensuse.org - HTTP OK: HTTP/1.1 200 OK - 7836 bytes in 0.085 second response time ; See https://monitor.opensuse.org/icinga/cgi-bin/extinfo.cgi?type=2&host=redmine.infra.opensuse.org&service=HTTP%20progress
2017-11-08T17:06:29  *** sven15 has quit IRC
2017-11-08T17:08:01  *** ancorgs has quit IRC
2017-11-08T17:30:07  *** fvogt has joined #opensuse-admin
2017-11-08T18:18:42  <tampakrap> cboltz: how about moving pillar/role/common to pillar/common/role to follow the same structure as for pillar/secrets?
2017-11-08T18:22:42  *** kl_eisbaer has quit IRC
2017-11-08T18:30:39  <cboltz> I'd prefer the other way round - pillar/role/secret
2017-11-08T18:31:16  *** Son_Goku has joined #opensuse-admin
2017-11-08T18:31:18  <cboltz> since role.common.* and role.secret.* will be included by role.something
2017-11-08T18:31:31  <cboltz> so we should keep them close to the file that includes them
2017-11-08T18:32:09  <tampakrap> I'd like not to put stuff that are not roles inside pillar/role
2017-11-08T18:32:21  *** Son_Goku has quit IRC
2017-11-08T18:32:38  <tampakrap> unless we do pillar/role/$role/secret.sls
2017-11-08T18:32:46  <tampakrap> or pillar/role/$role/common.sls
2017-11-08T18:36:05  <tampakrap> sounds better?
2017-11-08T18:38:46  <cboltz> at least it sounds like we have different preferences ;-)
2017-11-08T18:39:34  <cboltz> how would you handle a role with multiple secrets (like the ~20 database passwords for the wikis)?
2017-11-08T18:40:02  <tampakrap> all secrets in one file
2017-11-08T18:40:44  <tampakrap> I will look at pillar/role/wiki.sls that would point me to pillar/role/wiki/secrets.sls with proper comments
2017-11-08T18:41:58  <cboltz> that secrets.sls will be quite long, but if it only contains encrypted passwords, this isn't a real problem
2017-11-08T18:42:13  <tampakrap> exactly
2017-11-08T18:43:07  <cboltz> another question - where would you place pillar/role/common/wiki.sls? ("keep that place" is also an option - even if it then looks like "common" is also a role)
2017-11-08T18:43:45  <tampakrap> pillar/role/wiki/common.sls
2017-11-08T18:44:20  <tampakrap> the policy would be:
2017-11-08T18:44:34  <tampakrap> pillar/role/$ROLE.sls <- pillar states included from top.sls
2017-11-08T18:44:43  <cboltz> just as a reminder - it's used by the wiki and wikisearch roles, so it would be at the "wrong" place for wikisearch IMHO
2017-11-08T18:44:58  <tampakrap> pillar/role/$ROLE/*.sls <- pillar states included by pillar/role/$ROLE.sls
2017-11-08T18:45:18  <tampakrap> ah good point
2017-11-08T18:45:30  <cboltz> if you want to use subdirectories, pillar/role/$ROLE/init.sls is better than pillar/role/$ROLE.sls
2017-11-08T18:45:51  <cboltz> yeah, I know how to ask evil questions *eg*
2017-11-08T18:45:59  <tampakrap> I tend to believe that the common.sls is confusing and we should have gone with the wiki_subrole thing I proposed back then
2017-11-08T18:49:25  <cboltz> and I still believe common/* is the better solution for shared files ;-)
2017-11-08T18:49:50  <cboltz> but that's probably something you can't call "true" or "false"
2017-11-08T18:51:00  <tampakrap> it's not about being true or false
2017-11-08T18:51:14  <tampakrap> I tend to avoid includes from one pillar state to another, I find it confusing
2017-11-08T18:51:23  <tampakrap> and I'd like to stick to top.sls to do that
2017-11-08T18:53:56  <tampakrap> I'm curious now if we can trick the top.sls to not load pillar/role/$ROLE.sls if it doesn't exist
2017-11-08T18:54:01  <tampakrap> to get rid of those empty files
2017-11-08T18:54:40  <cboltz> you can do that by not adding empty roles ;-)
2017-11-08T18:54:54  <tampakrap> last time I checked it was complaining
2017-11-08T18:55:33  <cboltz> with "not adding empty roles", I mean not to mention the empty roles in pillar/id/*
2017-11-08T18:55:59  <tampakrap> there is a possibility that we have something in salt/role/$ROLE.sls but not in pillar/role/$ROLE.sls
2017-11-08T18:56:00  <cboltz> maybe you could also use some python magic to check if a file exists - but that's a receipe to hide errors
2017-11-08T18:56:35  <cboltz> yes, but IMHO we'll have to live with that because the alternative (hiding errors like filename typos) would be worse
2017-11-08T19:00:11  <cboltz> BTW: there's another thing that makes pillar/role/$ROLE/secrets.sls a bad idea - if it's used by two roles, like the wiki database passwords which should also be used by the mysql server
2017-11-08T19:00:35  <cboltz> pillar/secrets/wiki.sls could easily (and without confusion) be included by both
2017-11-08T19:00:36  <tampakrap> it won't be used by two files in this case
2017-11-08T19:00:44  <tampakrap> the keys will be different
2017-11-08T19:01:01  <tampakrap> we had this discussion already
2017-11-08T19:01:28  <cboltz> for the wiki, I can easily use mysql:whatever pillar data - "only" formulas will hit this problem
2017-11-08T19:02:01  <cboltz> and I really want to avoid that the database server and the database client accidently get a different password
2017-11-08T19:02:25  <cboltz> (won't happen when you setup something new, but it can easily happen if we want to change passwords one day)
2017-11-08T19:06:55  <tampakrap> https://github.com/saltstack/salt/issues/20010
2017-11-08T19:10:12  <cboltz> the last comment shows the file.file_exists python magic I had in mind
2017-11-08T19:10:54  <cboltz> but still, this is a receipe to hide errors like typos in the filename, and such errors will be funny[tm] to debug (they'll just look like "it doesn't work")
2017-11-08T19:18:40  <tampakrap> I tried it btw and it works
2017-11-08T19:18:46  <tampakrap> we'll get rid of many empty files
2017-11-08T19:18:52  <tampakrap> think about it please before you reject
2017-11-08T19:19:28  <cboltz> did I already mention that I'm not a fan of silently hiding errors?
2017-11-08T19:19:51  <tampakrap> but what about those empty files that will go away?
2017-11-08T19:20:23  <cboltz> I know we could get rid of empty files, but we'll hate it when we mistype a filename the first time and spend hours to find out why it doesn't work
2017-11-08T19:20:38  <cboltz> so the empty files are the smaller problem IMHO
2017-11-08T19:21:16  <tampakrap> what if I add a debug note there that this file is not found?
2017-11-08T19:22:00  <cboltz> you know that old joke about warnings vs. errors?
2017-11-08T19:22:14  <cboltz> "warnings are harmless. If they would be serious, they'd be an error and about the build"
2017-11-08T19:22:46  <tampakrap> I'm talking about a debug note, not about a warning
2017-11-08T19:23:11  <cboltz> that's more or less the same
2017-11-08T19:23:12  <tampakrap> also, we can add a CI test
2017-11-08T19:23:25  <cboltz> I'd translate it to "something nobody reads" ;-)
2017-11-08T19:23:34  <tampakrap> that checks if the roles mentioned in all of pillar/id do exist under pillar/role and salt/role
2017-11-08T19:23:57  <tampakrap> debug msg is something that someone reads when is trying to debug something, come on
2017-11-08T19:24:07  <tampakrap> there is a problem, I switch to debug mode, I read the messages
2017-11-08T19:24:22  <cboltz> I love your optimism ;-)
2017-11-08T19:24:26  <tampakrap> debug mode + CI test are fine?
2017-11-08T19:24:38  <cboltz> how would the CI know if missing files are intentional or by accident?
2017-11-08T19:25:06  <tampakrap> yeah I said it wrong
2017-11-08T19:25:10  <tampakrap> it will do it the other way around
2017-11-08T19:25:20  <tampakrap> if pillar/role and salt/role do exist under pillar/id
2017-11-08T19:25:46  <cboltz> so you basically want to check for unused roles?
2017-11-08T19:25:54  <tampakrap> yes
2017-11-08T19:26:07  <tampakrap> unused roles should either go away, be adjusted or are a typo
2017-11-08T19:26:34  <tampakrap> go away because they are deprecated
2017-11-08T19:26:40  <tampakrap> adjusted due to eg role rename
2017-11-08T19:27:18  <cboltz> that might indeed be an option, but I'm still not a fan of this idea
2017-11-08T19:28:34  <tampakrap> okay I'll work on it
2017-11-08T19:29:02  <cboltz> the CI is obviously a precondition ;-)
2017-11-08T19:29:34  <tampakrap> we have the CI already
2017-11-08T19:30:53  <tampakrap> ah it's not set up to salt-call the master
2017-11-08T19:30:55  <tampakrap> I'll do it now
2017-11-08T20:16:59  *** Son_Goku has joined #opensuse-admin
2017-11-08T20:18:27  *** Son_Goku has quit IRC
2017-11-08T20:30:49  <tampakrap> cboltz: ready
2017-11-08T20:30:57  <tampakrap> https://gitlab.infra.opensuse.org/infra/salt/merge_requests/76
2017-11-08T20:31:14  <tampakrap> https://gitlab.infra.opensuse.org/infra/salt/-/jobs/139
2017-11-08T20:31:40  <tampakrap> should I remove the os-release output maybe?
2017-11-08T20:32:18  <tampakrap> yeah I'll remove it
2017-11-08T20:32:44  <tampakrap> and I will hardcode the docker image version instead of using opensuse:latest
2017-11-08T20:43:34  <cboltz> the test result looks good :-)
2017-11-08T20:43:55  <cboltz> minion_roles in test_roles.py is unused
2017-11-08T20:44:14  <cboltz> do you have any plans for it? If not, just drop it ;-)
2017-11-08T20:44:18  <tampakrap> I know, but we may need them in the future
2017-11-08T20:44:22  <tampakrap> I have some ideas in my head
2017-11-08T20:44:46  <tampakrap> I can drop it now, I can recreate it later easily
2017-11-08T20:46:06  <tampakrap> gnoe
2017-11-08T20:46:08  <tampakrap> gone*
2017-11-08T20:47:38  <cboltz> another detail - can you please use python3 ?
2017-11-08T20:51:22  <tampakrap> I could try yes
2017-11-08T20:52:11  <cboltz> the biggest change you'll need is installing the py3 packages instead of the py2 packages
2017-11-08T20:52:44  <cboltz> in the script, you probably only need to change the #! header - everything else looks py3 compatible
2017-11-08T20:58:30  <tampakrap> works
2017-11-08T20:58:32  <tampakrap> https://gitlab.infra.opensuse.org/infra/salt/-/jobs/143
2017-11-08T20:58:38  <tampakrap> added also comment on the script
2017-11-08T21:03:07  <cboltz> :-)
2017-11-08T21:25:57  <tampakrap> so should I merge it or are you still reviewing something?
2017-11-08T21:30:28  <cboltz> feel free to merge
2017-11-08T21:30:49  <cboltz> and then do a follow-up merge request to make the test green ;-)
2017-11-08T21:31:06  <tampakrap> yes but please press the thumbs up button
2017-11-08T21:31:13  <tampakrap> to have it in history that someone reviewed
2017-11-08T21:32:16  <cboltz> done
2017-11-08T21:35:54  <tampakrap> excellent, thanks
2017-11-08T21:36:27  *** fvogt has quit IRC
2017-11-08T22:04:55  <tampakrap> cboltz: quick review https://gitlab.infra.opensuse.org/infra/salt/merge_requests/78 please
2017-11-08T22:06:18  <cboltz> nice catch :-)
2017-11-08T22:06:58  <tampakrap> it was caught by https://gitlab.infra.opensuse.org/infra/salt/-/jobs/151
2017-11-08T22:07:16  <tampakrap> which came from https://gitlab.infra.opensuse.org/infra/salt/merge_requests/77
2017-11-08T22:10:45  <tampakrap> yet another bug
2017-11-08T22:11:04  <cboltz> !77 also deletes several non-empty files and adds optional includes, so the title is completely misleading - but since it's WIP, I won't check the details for now
2017-11-08T22:12:22  <tampakrap> yeah I need to test it
2017-11-08T22:12:26  <tampakrap> I am thinking of splitting it
2017-11-08T22:12:32  <tampakrap> one run only for roles and test it
2017-11-08T22:12:36  <tampakrap> and then go on with the rest
2017-11-08T22:13:16  <tampakrap> fast review https://gitlab.infra.opensuse.org/infra/salt/merge_requests/79 as well please
2017-11-08T22:14:07  <tampakrap> caught by https://gitlab.infra.opensuse.org/infra/salt/-/jobs/155
2017-11-08T22:14:18  <cboltz> oh, "test is green" fails? nice ;-)
2017-11-08T22:14:40  <tampakrap> hahahaha yes
2017-11-08T22:14:47  <tampakrap> we never thought of that scenario
2017-11-08T22:15:03  <cboltz> lol
2017-11-08T22:15:20  <cboltz> just wondering - why don't you run the test script locally to catch all this?
2017-11-08T22:15:48  <tampakrap> I don't have a good answer to this :)
2017-11-08T22:16:53  <cboltz> well, you just produced a nice signature for me, so I won't complain too much ;-)
2017-11-08T22:17:52  <tampakrap> https://gitlab.infra.opensuse.org/infra/salt/-/jobs/159
2017-11-08T22:17:55  <tampakrap> much better
2017-11-08T22:18:49  <cboltz> :-)
2017-11-08T22:19:41  <cboltz> is there a config option to display the full branch name on https://gitlab.infra.opensuse.org/infra/salt/-/jobs ? tampakrap_emp... isn't really helpful ;-)
2017-11-08T22:21:23  <tampakrap> no, you'll need to click it
2017-11-08T22:23:36  <cboltz> I'd call that enforced shortening a bug...